Duplicate rows #1088
Merged
Duplicate rows #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additional test for styles
… default value of 1
|
@cbeltrangomez84 oops - my apologies, after I saw the original PR was merged, I went ahead and refactored it. I'll resolve the collisions so we can include your README changes. Thanks |
|
Hi @guyonroche thanks for refactoring the code, one test is failing because the default value for the 'insert' argument in my code was false. Since the refactor is true it doesn`t match the test. Could you change the argument? or if you prefer I'd change the test. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @Siemienik and @guyonroche for the suggestions.
I added the explanation in README as asked.
Regards