Skip to content

Support setting margins from cell comments #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Alanscut
Copy link
Member

@Alanscut Alanscut commented Mar 5, 2020

Changes

  1. The purpose of this PR is to support setting margins for cell comments.
  2. Please let me know if this PR needs anything else.

@Alanscut
Copy link
Member Author

Alanscut commented Mar 5, 2020

hi @guyonroche @Siemienik @alubbe , I sent you a email, if possible, I hope to be the maintainer of exceljs, looking forward to your reply and guidance, thanks!

@Alanscut Alanscut closed this Mar 6, 2020
@Siemienik
Copy link
Member

@Alanscut why did you close PR?

@Alanscut
Copy link
Member Author

Alanscut commented Mar 21, 2020

@Siemienik this PR is not complete, #1159 has replaced it.

@Siemienik
Copy link
Member

@Alanscut thanks

@Alanscut Alanscut deleted the comment_margins branch May 5, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy