Fix type definition for DefinedNamesRanges #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alubbe merged 1 commit into exceljs:master from antimatter15:patch-1

Oct 1, 2020

Contributor

antimatter15 commented Oct 1, 2020

Summary

The DefinedNamesRanges type actually has a ranges property, not a range property.

Test plan

This is the code that populates the named ranges list: https://github.com/exceljs/exceljs/blob/master/lib/doc/defined-names.js#L143

As you can tell the field is named ranges, not range


          Fix type definition for DefinedNamesRanges

7ccad76

alubbe approved these changes

View reviewed changes

Member

alubbe left a comment

thank you

alubbe merged commit ebb31f2 into exceljs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy