Skip to content

Fix spliceRows() issues with delete #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix spliceRows() issues with delete #1600

wants to merge 13 commits into from

Conversation

iva2k
Copy link
Contributor

@iva2k iva2k commented Jan 29, 2021

Summary

Fixes #674 #628 #474

Test plan

npm run test

There are couple new testcases that exercise deletes near the end of the worksheet rows. They fail prior to the spliceRows() code edits, and pass with the fixes.

@iva2k
Copy link
Contributor Author

iva2k commented Jan 29, 2021

Note that this PR includes PR 1599 (fixed lint violations).

@zhi-zhi-zhi
Copy link

"As it stands now, spliceRows() is useless to delete rows at the end of the worksheet."

I had this problem three hours ago. Thank you fix it!

@zhi-zhi-zhi
Copy link

BUT!
spliceColumns() is useless to delete rows at the end of the worksheet.

@Siemienik Siemienik self-requested a review February 12, 2021 02:26
Siemienik
Siemienik reviewed Feb 14, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started reviewing this PR, however I want getting done #1599 first.

@Siemienik
Copy link
Member

@iva2k could I please you to update this branch from the current master?

@iva2k
Copy link
Contributor Author

iva2k commented Feb 24, 2021

Not sure it has to be done as merge can be done automatically, there are no conflicts and all checks have passed. The actual fix is localized to 1 function. All other edits are to deal with this project not passing its own lint checks.

If you insist on me doing it - I was tied up with other stuff and still am. I will circle back to that perhaps in a couple of weeks, when my bandwidth opens up.

Siemienik
Siemienik reviewed Apr 11, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution! :)
From the code side and as the tests show, it works great - wonderful :)
However, I wonder a little bit about styling and cell formats. I'm going to check some variants before approval.

.gitignore
*.xlsx
*{}
Copy link
Member

@Siemienik Siemienik Apr 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What *{} mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These .gitignore items I added for test artifacts.

@Siemienik
Copy link
Member

Not sure it has to be done as merge can be done automatically

Ad the #1599 has been merged. Updating with master causing reduce the file to review from 19 to 5. Additionally, all tests run with up-to-date code.
Don't worry. I did it. 😄

@iva2k
Copy link
Contributor Author

iva2k commented Apr 13, 2021

I checked against master - no merge conflicts and no fails.

BTW, styling issues (if there are) are separate. This only deals with issue of not removing rows that should be removed.

@Siemienik Siemienik self-requested a review November 18, 2021 00:54
@OTheNonE
Copy link

Is this gonna be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Awaiting requested review from Siemienik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worksheet.spliceRows has inconsistent results based on splice count
4 participants
@iva2k @zhi-zhi-zhi @Siemienik @OTheNonE
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy