Skip to content

Increase resilience to generating large workbooks #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2023
Merged

Increase resilience to generating large workbooks #2320

merged 3 commits into from
Sep 19, 2023

Conversation

hfhchan-plb
Copy link
Contributor

Summary

Updates the xml-stream.js to generate a single string instead of multiple strings for each attribute or record of attributes.

Closes: #2303

@hfhchan-plb
Update xml-stream.js
3dccb3e 
Increase resilience to generating large workbooks
@hfhchan-plb
Copy link
Contributor Author

hfhchan-plb commented Aug 1, 2023 •
edited
Loading

@zurmokeeper I renamed the branch on my local repo and GitHub automatically closed #2319. So I needed to create a PR again. Sorry for the inconvenience.

@hfhchan-plb hfhchan-plb mentioned this pull request Aug 1, 2023
Closed
@hfhchan-plb hfhchan-plb changed the title Update xml-stream.js Increase resilience to generating large workbooks Aug 1, 2023
@zurmokeeper
Copy link
Contributor

@hfhchan-plb Could you please move over here? I'd be happy to merge this feature.

@hfhchan-plb
Copy link
Contributor Author

hfhchan-plb commented Aug 6, 2023 •
edited
Loading

@zurmokeeper I don't mind if you wish to cherry pick to your fork, with or without accreditation.

We are currently using our own fork for excel generation which is tracking upstream, so we are unlikely to move to a fork unless there is a good guarantee of maintainability, or a large technical benefit (i.e. completely rewritten in TypeScript, using Web Streams API, no dependencies on outdated libraries, etc).

@Siemienik
Copy link
Member

Siemienik commented Sep 19, 2023 •
edited
Loading

Sorry for some inconvenience recently, now I'm able to resume active development - more info would be found in a topic about next release v4.4.0: #2352

Siemienik
Siemienik approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, Thank you @hfhchan-plb

@Siemienik Siemienik merged commit 804775a into exceljs:master Sep 19, 2023
@hfhchan-plb hfhchan-plb deleted the fix-large-file-export branch September 20, 2023 06:16
@Yumitoya8569 Yumitoya8569 mentioned this pull request Aug 6, 2024
Closed
@j-mendez j-mendez mentioned this pull request Sep 8, 2024
Open
@Vishwas1 Vishwas1 mentioned this pull request Sep 8, 2024
Open
@j-mendez j-mendez mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
gltjk added a commit to gltjk/excelize that referenced this pull request Feb 21, 2025
@gltjk
Increase resilience to generating large workbooks
60e33a5 
Port the same feature from PR [#2320](exceljs/exceljs#2320) by @hfhchan-plb from [ExcelJS](https://github.com/exceljs/exceljs/)
@gltjk gltjk mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Out-of-memory with lots of cells
3 participants
@hfhchan-plb @zurmokeeper @Siemienik
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy