Image positioning fix #691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you're the man! |
Siemienik
requested changes
Jan 16, 2019
|
@kaidoj so the only change is here, right? https://github.com/exceljs/exceljs/pull/691/files#diff-36f4b57761a8f069733aa289ffdcb1c3 could you remove all the noise from this PR and extract a test case? Or close the PR if this is no longer relevant? |
|
Closing this. This works for me atm. I have no time to test the alternative #702. If @Siemieniks PR works and is fine, then merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix as discussed #467
As the original fix author https://github.com/Trynex did not create pull request then i will.
I did test it and this fixed my issue.