Skip to content

Feature/Sheet Protection #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 15, 2019
Merged

Feature/Sheet Protection #907

merged 9 commits into from
Aug 15, 2019

Conversation

karabaesh
Copy link
Contributor

Changes:

  • New feature: Ability to protect and unprotect worksheets

@karabaesh karabaesh changed the title New feature: Sheet protection Feature/Sheet-Protection Jul 31, 2019
@karabaesh karabaesh changed the title Feature/Sheet-Protection Feature/Sheet Protection Jul 31, 2019
@karabaesh karabaesh mentioned this pull request Jul 31, 2019
Closed
karabaesh added 2 commits July 31, 2019 15:10
@karabaesh
Fix sheet protection options
1d9c481 
Signed-off-by: Karabaesh <karabaesh@users.noreply.github.com>
@karabaesh
Fix unit test 'encryptor'
3f02ae4
Siemienik
Siemienik approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, It's a great request:)

Everything from code side looks fine for me, so I approve it.

Could anyone confirm that this feature works fine?

guyonroche
guyonroche requested changes Aug 12, 2019
View reviewed changes
Copy link
Collaborator

@guyonroche guyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karabaesh Thank you for working on this PR - it will be a great addition to exceljs
I've made a few comments - could you take a look?

guyonroche
guyonroche requested changes Aug 12, 2019
View reviewed changes
karabaesh
karabaesh commented Aug 13, 2019
View reviewed changes
Copy link
Contributor Author

@karabaesh karabaesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied some changed according to guyonroche's requests.

guyonroche
guyonroche requested changes Aug 13, 2019
View reviewed changes
karabaesh
karabaesh commented Aug 14, 2019
View reviewed changes
Copy link
Contributor Author

@karabaesh karabaesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been implemented

@guyonroche guyonroche merged commit 28a7802 into exceljs:master Aug 15, 2019
@Siemienik Siemienik mentioned this pull request Feb 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonroche guyonroche guyonroche requested changes

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karabaesh @guyonroche @Siemienik
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy