feat: nominate @Phillip9587 as committer to jshttp/on-finished #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
approved these changes
May 11, 2025
IamLizu
approved these changes
May 11, 2025
bjohansebas
approved these changes
May 11, 2025
|
Hey @wesleytodd! Sorry for the ping but it would be nice to get this approved from your side. |
wesleytodd
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Looks like there is one extraneous change, but 100% on board with this! Thanks for the great work @Phillip9587!
wesleytodd
pushed a commit
that referenced
this pull request
Jul 22, 2025
|
I think I correctly setup the team. @Phillip9587 let me know if I missed anything and you do not have write access. |
|
Thanks @wesleytodd! I think it worked - I can now merge PRs. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.