Skip to content

skip QUERY tests for Node 21 only, still not supported #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove skip message, doesn't seem to work
  • Loading branch information
jonchurch committed Jun 8, 2024
commit fcf7ca62d260074b2c5e119ae79cda0a427f9c2f
2 changes: 1 addition & 1 deletion test/app.router.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('app.router', function(){

it('should include ' + method.toUpperCase(), function(done){
if (method === 'query' && shouldSkipQuery(process.versions.node)) {
this.skip("QUERY is not fully supported in this version of Node")
this.skip()
}
var app = express();

Expand Down
2 changes: 1 addition & 1 deletion test/res.send.js
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ describe('res', function(){

it('should send ETag in response to ' + method.toUpperCase() + ' request', function (done) {
if (method === 'query' && shouldSkipQuery(process.versions.node)) {
this.skip("QUERY is not fully supported in this version of Node")
this.skip()
}
var app = express();

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy