Skip to content

Deprecate "back" magic string in redirects #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Deprecate "back" magic string in redirects #5935

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88b4e4
Deprecate back magic string
blakeembrey Sep 10, 2024
b663715
Use short URL
blakeembrey Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Deprecate back magic string
  • Loading branch information
@blakeembrey
blakeembrey committed Sep 10, 2024
commit c88b4e45268d2ddc5c1e8cbedc3fadafcc66b6c1
5 changes: 5 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
unreleased
==========

* Deprecate `res.location("back")` and `res.redirect("back")` magic string

4.20.0 / 2024-09-10
==========
* deps: serve-static@0.16.0
Expand Down
1 change: 1 addition & 0 deletions lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@ res.location = function location(url) {

// "back" is an alias for the referrer
if (url === 'back') {
deprecate('res.location("back"): use res.location(req.get("Referrer") || "/") and refer to https://expressjs.com/en/advanced/best-practice-security.html#prevent-open-redirects for best practices');
loc = this.req.get('Referrer') || '/';
} else {
loc = String(url);
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy