ci: run CI when the markdown changes #6632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivarm
reviewed
Jul 15, 2025
There was a problem hiding this comment.
@bjohansebas But CI is mostly related to node.js so why we need this or why should we run CI for markdown files changes?
|
Because it’s necessary for the CI to pass in order to merge. If the CI doesn’t run (since I only changed markdown files, see #6543, #6570), then I can’t merge. To merge, I would have to bypass the branch rules, which only an admin can do. Also, bypassing branch rules is something we want to avoid at all times (see expressjs/discussions#391). |
ctcpip
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are changes in a markdown file, the CI does not run, which means the PR cannot be merged without bypassing the branch protections.