Adding LazyThreadPoolExecutor class #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ThreadPoolExecutor docs: the iterables are collected immediately rather than lazily
This can cause memory/timeout issues for large or infinite
Original issue: http://forums.fast.ai/t/memory-error-not-cuda-out-of-memory-error/12481
Fixed in this PR: c0e9bd9. Just adding an alternative
Original method copied from this PR - python/cpython#707
Has not been merged to the CPython library. Made a few style changes here: c112c3f
Tested here: bearpelican@e72df56