Add option to hide altText #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to hide the alternative text by introducing a new punctuation position ("None") in the theme preferences and updating the keyboard view accordingly.
- Introduces a new method (applyNoAltTextPosition) in KeyView.kt to reset layout parameters and hide the altText.
- Adds a new enum value (None) in PunctuationPosition within ThemePrefs.kt to support this new behavior.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/org/fcitx/fcitx5/android/input/keyboard/KeyView.kt | Adds a new function to handle the layout changes when alternative text is hidden |
| app/src/main/java/org/fcitx/fcitx5/android/data/theme/ThemePrefs.kt | Introduces a new enum option to select the "None" punctuation position |
Files not reviewed (1)
- app/src/main/res/values/strings.xml: Language not supported
|
|
mokapsing
pushed a commit
to mokapsing/fcitx5-android
that referenced
this pull request
May 12, 2025
Co-authored-by: Rocka <i@rocka.me>
wxyzh
pushed a commit
to wxyzh/fcitx5-android
that referenced
this pull request
Jun 7, 2025
Co-authored-by: Rocka <i@rocka.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.