rustfmt: Link style guide and embed config options
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
commented
Jun 18, 2024
pietroalbini
approved these changes
Jun 19, 2024
|
bors merge |
bors-ferrocene bot
added a commit
that referenced
this pull request
Jun 19, 2024
709: `rustfmt`: Link style guide and embed config options r=Urhengulas a=Urhengulas 712: Stripped white line to avoid conflict, same as beta. r=Urhengulas a=Dajamante #710 713: Update stamp following this change r=Veykril a=Dajamante Following changes in: rust-lang/rust#125141 in [ff25b24](ff25b24), only upstream download configuration was changed. 714: Add more annotations for single tested only paragraphs r=pietroalbini a=Veykril This just adds a few more annotations for some that only have a single test associated (there are still more) Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com> Co-authored-by: aissata <aimaiga2@gmail.com> Co-authored-by: Lukas Wirth <lukas.wirth@ferrous-systems.com>
|
Build failed (retrying...): |
bors-ferrocene bot
added a commit
that referenced
this pull request
Jun 19, 2024
680: Enable compiler-arguments/target test on all platforms r=tshepang a=Veykril Allows enabling the remaining target test after #679 709: `rustfmt`: Link style guide and embed config options r=Urhengulas a=Urhengulas 712: Stripped white line to avoid conflict, same as beta. r=Urhengulas a=Dajamante #710 Co-authored-by: Lukas Wirth <lukas.wirth@ferrous-systems.com> Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com> Co-authored-by: aissata <aimaiga2@gmail.com>
|
Build failed (retrying...): |
bors-ferrocene bot
added a commit
that referenced
this pull request
Jun 20, 2024
709: `rustfmt`: Link style guide and embed config options r=Urhengulas a=Urhengulas 712: Stripped white line to avoid conflict, same as beta. r=Urhengulas a=Dajamante #710 Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com> Co-authored-by: aissata <aimaiga2@gmail.com>
|
Build failed (retrying...):
|
|
Build failed:
|
|
It is more correct to say well-formatted than well formatted. Separating the words with space would work better if the words were swapped... formatted well. |
tshepang
reviewed
Jun 20, 2024
tshepang
reviewed
Jun 20, 2024
2aa721c to
c964a03
Compare
Changed it to "well-formatted" everywhere. |
c964a03 to
bc9fa42
Compare
9bf491e to
03acf4a
Compare
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded:
|
pietroalbini
reviewed
Jul 1, 2024
| ------------- | ||
|
|
||
| By default ``rustfmt`` formats code according to the | ||
| `Rust Style Guide <../../../doc/style-guide/index.html>`_. The formatting can |
There was a problem hiding this comment.
Why do you have the ../doc here?
There was a problem hiding this comment.
Good question, probably that is the reason why the link is broken on the published docs (https://ferroussystems.clickup.com/t/8694zvgt3).
There was a problem hiding this comment.
Suggested change
| `Rust Style Guide <../../../doc/style-guide/index.html>`_. The formatting can | |
| `Rust Style Guide <../../style-guide/index.html>`_. The formatting can |
ferrocene-automations bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Reenable run-make tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.