-
Notifications
You must be signed in to change notification settings - Fork 1
Update @antfu/eslint-config #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe updates across various files reflect a shift in variable management within a Vue component, alterations in string templates for localization, a minor text change in test descriptions, and a tweak in error handling for a test suite. Additionally, there's an update to the ESLint configuration to adopt a new rule set and adjust a specific rule preference, alongside a logical enhancement in the loader query function for better custom block handling. Changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 74.17% 74.17%
=======================================
Files 6 6
Lines 151 151
Branches 27 27
=======================================
Hits 112 112
Misses 32 32
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (4)
- tests/frameworks/vite/snapshots/external.spec.ts.snap
- package.json
- pnpm-lock.yaml
- tsconfig.json
Files selected for processing (7)
- tests/fixtures/components/external.setup.vue (1 hunks)
- tests/fixtures/noLocale.vue (1 hunks)
- tests/fixtures/test.vue (1 hunks)
- tests/frameworks/vite/errors.spec.ts (1 hunks)
- tests/frameworks/webpack/sfc.spec.ts (1 hunks)
- eslint.config.js (1 hunks)
- src/loader-query.ts (1 hunks)
Files skipped from review due to trivial changes (4)
- tests/fixtures/noLocale.vue
- tests/fixtures/test.vue
- tests/frameworks/vite/errors.spec.ts
- eslint.config.js
Additional comments: 3
__tests__/fixtures/components/external.setup.vue (1)
- 1-3: The change from
test
touserName
seems to align with the updated string templates that useuserName
. Ensure that this variable change is reflected everywheretest
was used.src/loader-query.ts (1)
- 38-39: The added conditions in the
isCustomBlock
function seem to correctly implement the intended logic for handling custom blocks with webpack. Verify that theoptions.blockType
is always provided when this function is called to avoid potential issues.__tests__/frameworks/webpack/sfc.spec.ts (1)
- 47-48: The syntax correction in the
expect
statement now properly closes thetoContainEqual
matcher. This change should prevent any syntax errors during test execution.
Update eslint config