Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make
PageTransitionsTheme
conform to Flutter Material's conventions for component themes:PageTransitionsThemeData
class which defines overrides for the configuration forPageTransitionsTheme
.PageTransitionsThemeData? data
andWidget? child
. This is now the preferred way to configure aPageTransitionsTheme
:These two properties are made nullable to not break existing apps which has customized
ThemeData.pageTransitionsTheme
.PageTransitionsTheme
to be anInheritedWidget
subclass.PageTransitionsTheme
andPageTransitionsThemeData
, and update the existingPageTransitionsTheme
tests.PageTransitionsThemeData
toObject?
inThemeData
class, to bypass g3 tests.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.