Fix: broadcast extension not found fallback logic #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling the latest from the webrtc team
fix: replaced logic fetching 'infoDictionary' value
daniel-g-favoreto-opl
pushed a commit
to daniel-g-favoreto-opl/flutter-webrtc
that referenced
this pull request
Mar 24, 2025
* replaced logic fetching 'infoDictionary' value * better fallback in the event the RTCScreenSharingExtension key doesn't exist * added a log in case the screen sharing extention id is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #1345.
It turns out that the issue is caused by a bad "fallback" if the
RTCScreenSharingExtensionis not found. The instructions found here don't mention that we should set the extension id there.In all cases though, it would be nice to update the instructions found here.
With this solution, if the key is not found, the broadcast selector lists what I suspect to be all the other available extensions.