RECORDINGS - Add fallback resolutions for unsupported stream frame sizes on low-end Android devices #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantunes22
approved these changes
Jul 28, 2025
|
LGTM |
cloudwebrtc
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fallback resolutions to handle cases where the default stream frame resolution is not supported by the device. This issue typically occurs on low-end Android devices that lack support for higher resolutions. With this change, the system will automatically attempt to use compatible resolutions to ensure stream encoding continues without crashing.
Example:
If the original stream resolution is QHD and the encoder fails to configure it, the system will automatically fallback to FHD and try again. This process continues down the list of fallback resolutions until one is successfully configured.