Skip to content

Additional sessions data added for CSV export #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

Additional sessions data added for CSV export #5566

merged 1 commit into from
Jan 31, 2019

Conversation

mrsaicharan1
Copy link
Member

Fixes #5519

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

  • Added additional data for CSV export(Title, duration...)

Changes proposed in this pull request:

  • Export data changed

@mrsaicharan1
Copy link
Member Author

@CosmicCoder96 Closed the previous PR due to commit history mismtach. I think this PR shouldn't be having a problem. Would be great if you could verify.

@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #5566 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5566   +/-   ##
============================================
  Coverage        63.23%   63.23%           
============================================
  Files              265      265           
  Lines            12742    12742           
============================================
  Hits              8057     8057           
  Misses            4685     4685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fbb72...2a65655. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 86c08bb into fossasia:development Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session Export CSV does not include all data
3 participants
@mrsaicharan1 @iamareebjamal @abhinavk96
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy