Make it possible to delete expired orders #5570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #5570 +/- ##
============================================
Coverage 63.23% 63.23%
============================================
Files 265 265
Lines 12742 12742
============================================
Hits 8057 8057
Misses 4685 4685
Continue to review full report at Codecov.
|
iamareebjamal
approved these changes
Jan 31, 2019
iamareebjamal
approved these changes
Jan 31, 2019
iamareebjamal
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5569
Short description of what this resolves:
The redundant fetch arg made it possible to delete the session only if the creator of the order was authenticated. It prevented the event organizers and co-organizers from deleting the order.