[comms] Devices send Reset signal when they reset #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
954be5f to
42a3d38
Compare
d9913ec to
e112409
Compare
Weird bugs in the Linux kernel driver for ACM CDC devices was being triggered by our aggressive disconnect and reconnect for devices that had finished firmware upgrade. It happened so fast that data got corrupted somehow. Now we only disconnect the port once the device has cleanly finished the upgrade and sent our reset signal.
e112409 to
98ad4ef
Compare
|
ACK 98ad4ef. I just got rid of an unused method @nickfarrow introduced in the last commit. Please approve and merge @nickfarrow. |
|
Which unused method? Hard to see because of rebase + changes in same forcepush |
nickfarrow
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weird bugs in the Linux kernel driver for ACM CDC devices was being triggered by our aggressive disconnect and reconnect for devices that had finished firmware upgrade. It happened so fast that data got corrupted somehow by the CDC ACM control message
2122030000000000. Now we only disconnect the port once the device has cleanly finished the upgrade and sent our reset signal.