Skip to content

[GHSA-x8qp-wqqm-57ph] vue-i18n's escapeParameterHtml does not prevent DOM-based XSS through its tag attributes #5819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

luoingly
Copy link

Updates

  • Description

Comments
In the summary part it mentioned a payload example <img src=x onerror=...> without back quote wrapped, so GitHub render it as an HTML img tag, which is not a good idea so I wrap it up.

@github
Copy link
Collaborator

github commented Jul 17, 2025

Hi there @kazupon! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 07:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a documentation rendering issue in a security advisory for vue-i18n. The change prevents GitHub from rendering an XSS payload example as actual HTML by wrapping it in backticks.

  • Wraps a potentially dangerous HTML payload example in backticks to prevent GitHub from rendering it as HTML
  • Updates the modification timestamp to reflect the change

@github-actions github-actions bot changed the base branch from main to luoingly/advisory-improvement-5819 July 17, 2025 07:28
@advisory-database advisory-database bot merged commit 718d582 into luoingly/advisory-improvement-5819 Jul 17, 2025
4 checks passed
@advisory-database
Copy link
Contributor

Hi @luoingly! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the luoingly-GHSA-x8qp-wqqm-57ph branch July 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy