Java: minor refactor

github · jcogs33 · Apr 22, 2025 · Mar 20, 2025 · Mar 20, 2025 · Mar 20, 2025
commit 44445dbeb8230e7a93c531e249e9dd95846e76d0
diff --git a/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotUseFinalize.ql b/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotUseFinalize.ql
@@ -13,10 +13,9 @@
 
 import java
 
-from MethodCall mc, Method m
+from MethodCall mc
 where
-  mc.getMethod() = m and
-  m.hasName("finalize") and
+  mc.getMethod().hasName("finalize") and
   // The Java documentation for `finalize` states: "If a subclass overrides
   // `finalize` it must invoke the superclass finalizer explicitly". Therefore,
   // we do not alert on `super.finalize` calls that occur within a callable