-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rust: upgrade rust-analyzer
to 0.0.285
#19524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cc2e8ab
to
28b504a
Compare
rust-analyzer
to 0.0.279rust-analyzer
to 0.0.281
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QL changes LGTM.
I've raised some questions on the DCA run, it looks like a net gain but there are some regressions in there that deserve discussing.
Extractor changes not reviewed.
rust/ql/test/library-tests/type-inference/type-inference.expected
Outdated
Show resolved
Hide resolved
rust-analyzer
to 0.0.281rust-analyzer
to 0.0.285
Looks good to me. The additional path resolution inconsistencies are a bit annoying though. Any idea where they come from? |
Judging by the second DCA run it looks like we're extracting significantly fewer files successfully as well - though the run did fail so I don't want to read too much into that. |
Don't know, there are still loads of unexpanded macros around :sigh: |
I've opened rust-lang/rust-analyzer#19931 (as I couldn't reopen rust-lang/rust-analyzer#19873). |
No description provided.