Skip to content

Java: Tag quality queries with quality and sub-category #19799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025
Merged

Java: Tag quality queries with quality and sub-category #19799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97dceb3
Tag with `quality` and sub-category
owen-mc Jun 17, 2025
72a6280
Add change note
owen-mc Jun 17, 2025
9cfa6fe
Update expected quality queries
owen-mc Jun 17, 2025
d3eb4f8
Remove query with hard-coded threshold
owen-mc Jun 18, 2025
b8a694c
Address review comments
owen-mc Jun 18, 2025
7a50298
Update query suite test expectation
owen-mc Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Tag with quality and sub-category
  • Loading branch information
@owen-mc
owen-mc committed Jun 18, 2025
commit 97dceb3a1c84891140d93863bd2681bd08d65bf9
4 changes: 3 additions & 1 deletion java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision high
* @id java/missing-override-annotation
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

import java
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision high
* @id java/deprecated-call
* @tags maintainability
* @tags quality
* maintainability
* readability
* non-attributable
* external/cwe/cwe-477
*/
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision high
* @id java/inconsistent-javadoc-throws
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

import java
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision very-high
* @id java/unknown-javadoc-parameter
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

import java
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision high
* @id java/jdk-internal-api-access
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

import java
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity recommendation
* @precision high
* @id java/underscore-identifier
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

import java
Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/DeadCode/UselessParameter.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity recommendation
* @precision high
* @id java/unused-parameter
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* external/cwe/cwe-561
*/
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Language Abuse/ChainedInstanceof.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity recommendation
* @precision high
* @id java/chained-type-tests
* @tags maintainability
* @tags quality
* maintainability
* complexity
* language-features
*/

Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Language Abuse/IterableIterator.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
* @problem.severity warning
* @precision very-high
* @id java/iterator-implements-iterable
* @tags correctness
* @tags quality
* reliability
* correctness
*/

import java
Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Language Abuse/UselessNullCheck.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity warning
* @precision very-high
* @id java/useless-null-check
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* external/cwe/cwe-561
*/
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Language Abuse/UselessTypeTest.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision very-high
* @id java/useless-type-test
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* language-features
* external/cwe/cwe-561
*/
Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Language Abuse/WrappedIterator.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* @problem.severity warning
* @precision very-high
* @id java/iterable-wraps-iterator
* @tags correctness
* @tags quality
* reliability
* correctness
*/

import java
Expand Down
5 changes: 3 additions & 2 deletions java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* @problem.severity warning
* @precision very-high
* @id java/evaluation-to-constant
* @tags maintainability
* useless-code
* @tags quality
* reliability
* correctness
*/

import java
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
* @problem.severity warning
* @precision very-high
* @id java/integer-multiplication-cast-to-long
* @tags reliability
* @tags quality
* reliability
* correctness
* types
* quality
* external/cwe/cwe-190
* external/cwe/cwe-192
* external/cwe/cwe-197
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Likely Bugs/Arithmetic/LShiftLargerThanTypeWidth.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision very-high
* @id java/lshift-larger-than-type-width
* @tags correctness
* @tags quality
* reliability
* correctness
*/

import java
Expand Down
5 changes: 3 additions & 2 deletions java/ql/src/Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* @problem.severity warning
* @precision very-high
* @id java/whitespace-contradicts-precedence
* @tags maintainability
* readability
* @tags quality
* reliability
* correctness
* external/cwe/cwe-783
*/

Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Collections/ArrayIndexOutOfBounds.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity error
* @precision high
* @id java/index-out-of-bounds
* @tags reliability
* @tags quality
* reliability
* correctness
* exceptions
* external/cwe/cwe-193
Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity error
* @precision very-high
* @id java/type-mismatch-access
* @tags reliability
* @tags quality
* reliability
* correctness
* logic
*/
Expand Down
6 changes: 3 additions & 3 deletions java/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
* @problem.severity error
* @precision very-high
* @id java/empty-container
* @tags reliability
* maintainability
* useless-code
* @tags quality
* reliability
* correctness
* external/cwe/cwe-561
*/

Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Collections/RemoveTypeMismatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity error
* @precision very-high
* @id java/type-mismatch-modification
* @tags reliability
* @tags quality
* reliability
* correctness
* logic
*/
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
* @problem.severity error
* @precision very-high
* @id java/unused-container
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* quality
* external/cwe/cwe-561
*/

Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Comparison/CompareIdenticalValues.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity error
* @precision very-high
* @id java/comparison-of-identical-expressions
* @tags reliability
* @tags quality
* reliability
* correctness
* logic
*/
Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Comparison/EqualsArray.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity error
* @precision very-high
* @id java/equals-on-arrays
* @tags reliability
* @tags quality
* reliability
* correctness
*/

Expand Down
3 changes: 2 additions & 1 deletion java/ql/src/Likely Bugs/Comparison/HashedButNoHash.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity error
* @precision very-high
* @id java/hashing-without-hashcode
* @tags reliability
* @tags quality
* reliability
* correctness
*/

Expand Down
5 changes: 3 additions & 2 deletions java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
* @problem.severity error
* @precision very-high
* @id java/equals-on-unrelated-types
* @tags reliability
* @tags quality
* reliability
* correctness
* quality
* external/cwe/cwe-571
*/

import java
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* @problem.severity error
* @precision very-high
* @id java/inconsistent-equals-and-hashcode
* @tags reliability
* @tags quality
* reliability
* correctness
* quality
* external/cwe/cwe-581
*/

Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* @problem.severity error
* @precision high
* @id java/unchecked-cast-in-equals
* @tags reliability
* @tags quality
* reliability
* correctness
* quality
*/

import java
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* @problem.severity error
* @precision very-high
* @id java/reference-equality-of-boxed-types
* @tags reliability
* @tags quality
* reliability
* correctness
* quality
* external/cwe/cwe-595
*/

Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Likely Bugs/Comparison/UselessComparisonTest.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
* @problem.severity warning
* @precision very-high
* @id java/constant-comparison
* @tags correctness
* @tags quality
* reliability
* correctness
* logic
* external/cwe/cwe-570
* external/cwe/cwe-571
Expand Down
4 changes: 3 additions & 1 deletion java/ql/src/Likely Bugs/Comparison/WrongNanComparison.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @problem.severity error
* @precision very-high
* @id java/comparison-with-nan
* @tags correctness
* @tags quality
* reliability
* correctness
*/

import java
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/CallsToRunnableRun.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
* @problem.severity recommendation
* @precision high
* @id java/call-to-thread-run
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* external/cwe/cwe-572
*/
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLocking.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
* @problem.severity error
* @precision high
* @id java/unsafe-double-checked-locking
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* external/cwe/cwe-609
*/
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLockingWithInitRace.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
* @problem.severity warning
* @precision high
* @id java/unsafe-double-checked-locking-init-order
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* external/cwe/cwe-609
*/
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
* @problem.severity warning
* @precision very-high
* @id java/non-sync-override
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* language-features
* external/cwe/cwe-820
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/SynchOnBoxedType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
* @problem.severity error
* @precision very-high
* @id java/sync-on-boxed-types
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* language-features
* external/cwe/cwe-662
Expand Down
4 changes: 2 additions & 2 deletions java/ql/src/Likely Bugs/Concurrency/SynchSetUnsynchGet.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
* @problem.severity error
* @precision very-high
* @id java/unsynchronized-getter
* @tags reliability
* correctness
* @tags quality
* reliability
* concurrency
* language-features
* external/cwe/cwe-413
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy