Skip to content

Shared: Improve sensitive data heuristics #20024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 23, 2025
Merged

Shared: Improve sensitive data heuristics #20024

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
99e62d6
Rust: Add sensitive data patterns.
geoffw0 May 9, 2025
8f95e26
Rust: Combine regexs where possible (likely better performance).
geoffw0 May 9, 2025
a6b4a18
Rust: Add negative patterns.
geoffw0 May 9, 2025
123458f
Sync identical files.
geoffw0 Jul 10, 2025
8f6f9f4
Add change notes.
geoffw0 Jul 11, 2025
4778ef6
Rust: Add a test case for password_confirmation.
geoffw0 Jul 11, 2025
9f59a35
Rust: Revert ipaddr and fingerprint terms (too many FPs).
geoffw0 Jul 14, 2025
e121579
Rust: Adjust the test labels slightly.
geoffw0 Jul 14, 2025
30c6082
Sync identical files.
geoffw0 Jul 14, 2025
da0742f
Rust: Update path resolution consistency .expected.
geoffw0 Jul 14, 2025
918700f
Merge branch 'main' into moresensitive2
geoffw0 Jul 14, 2025
4f6b698
Merge branch 'main' into moresensitive2
geoffw0 Jul 23, 2025
68f0dfe
Shared: Fix after merge.
geoffw0 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rust: Adjust the test labels slightly.
  • Loading branch information
@geoffw0
geoffw0 committed Jul 14, 2025
commit e121579a857da542402e4362d43b0e82e08e21c7
7 changes: 5 additions & 2 deletions rust/ql/test/library-tests/sensitivedata/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,17 @@ impl DeviceInfo {
sink(&self.api_key); // $ sensitive=password
sink(&other.api_key); // $ sensitive=password
sink(&self.deviceApiToken); // $ sensitive=password
sink(&self.finger_print); // $ MISSING: sensitive=private
sink(&self.ip_address); // $ MISSING: sensitive=private
sink(self.macaddr12); // $ sensitive=private
sink(&self.mac_addr); // $ sensitive=private
sink(self.mac_addr.values); // $ sensitive=private
sink(self.mac_addr.values[0]); // $ sensitive=private
sink(&self.networkMacAddress); // $ sensitive=private

// dubious (may or may not be private device info, depending on context)

sink(&self.finger_print);
sink(&self.ip_address);

// not private device info

sink(self.macro_value);
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy