Skip to content

Swift: Diff-informed queries: phase 3 (non-trivial locations) #20082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025
Merged

Swift: Diff-informed queries: phase 3 (non-trivial locations) #20082

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd3fa64
[DIFF-INFORMED] Swift: CleartextStorageDatabase
d10c Jul 16, 2025
6dea73b
[DIFF-INFORMED] Swift: CleartextStoragePreferences
d10c Jul 16, 2025
b1e7239
[DIFF-INFORMED] Swift: InsecureTLS
d10c Jul 16, 2025
4342b2b
[DIFF-INFORMED] Swift: UnsafeWebViewFetch
d10c Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[DIFF-INFORMED] Swift: UnsafeWebViewFetch 
https://github.com/d10c/codeql/blob/d10c/diff-informed-phase-3/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql#L24
  • Loading branch information
@d10c
d10c committed Jul 17, 2025
commit 4342b2b799aa7877ee1131fe3f5b6db0045cc85e
4 changes: 4 additions & 0 deletions swift/ql/lib/codeql/swift/security/UnsafeWebViewFetchQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ module UnsafeWebViewFetchConfig implements DataFlow::ConfigSig {
predicate isAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
any(UnsafeWebViewFetchAdditionalFlowStep s).step(nodeFrom, nodeTo)
}

predicate observeDiffInformedIncrementalMode() {
none() // can't override location accurately because of secondary use in select.
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue here? The only unusual thing I can see in that query is selecting from three possible alert messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is the second flow call (UnsafeWebViewFetchFlow::flowToExpr) in the third disjunct: we can't include it in the location override because of monotonic recursion, but if we exclude it then the --check-diff-informed test fails, as it usually does with these cases of secondary flows. So we can't make these queries diff-informed, but their incrementality story will be handled separately using overlay-informed dataflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation.

}

/**
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy