Skip to content

Rust: Remove sourceModelDeprecated, summaryModelDeprecated and sinkModelDeprecated #20109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
+11 −141
Merged

Rust: Remove sourceModelDeprecated, summaryModelDeprecated and sinkModelDeprecated #20109

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69d50e1
Initial plan
Copilot Jul 23, 2025
0245cd8
Remove deprecated Rust dataflow predicates and associated classes
Copilot Jul 23, 2025
2cc732e
Apply QL autoformatter to ModelsAsData.qll
Copilot Jul 23, 2025
f1df636
Add CodeQL autoformatter instructions to copilot-instructions.md
Copilot Jul 23, 2025
defd4a1
Add change note for removal of deprecated dataflow predicates
Copilot Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply QL autoformatter to ModelsAsData.qll 
Co-authored-by: geoffw0 <40627776+geoffw0@users.noreply.github.com>
  • Loading branch information
@Copilot @geoffw0
Copilot and geoffw0 committed Jul 23, 2025
commit 2cc732e23532e11ad4b8f7b20e0ac6d8b34b8d2f
12 changes: 0 additions & 12 deletions rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ private import codeql.rust.dataflow.FlowSource
private import codeql.rust.dataflow.FlowSink
private import codeql.rust.elements.internal.CallExprBaseImpl::Impl as CallExprBaseImpl



/**
* Holds if in a call to the function with canonical path `path`, the value referred
* to by `output` is a flow source of the given `kind`.
Expand All @@ -64,8 +62,6 @@ extensible predicate sourceModel(
string path, string output, string kind, string provenance, QlBuiltins::ExtensionId madId
);



/**
* Holds if in a call to the function with canonical path `path`, the value referred
* to by `input` is a flow sink of the given `kind`.
Expand All @@ -80,8 +76,6 @@ extensible predicate sinkModel(
string path, string input, string kind, string provenance, QlBuiltins::ExtensionId madId
);



/**
* Holds if in a call to the function with canonical path `path`, the value referred
* to by `input` can flow to the value referred to by `output`.
Expand Down Expand Up @@ -116,8 +110,6 @@ predicate interpretModelForTest(QlBuiltins::ExtensionId madId, string model) {
)
}



private class SummarizedCallableFromModel extends SummarizedCallable::Range {
private string path;

Expand Down Expand Up @@ -146,8 +138,6 @@ private class SummarizedCallableFromModel extends SummarizedCallable::Range {
}
}



private class FlowSourceFromModel extends FlowSource::Range {
private string path;

Expand All @@ -164,8 +154,6 @@ private class FlowSourceFromModel extends FlowSource::Range {
}
}



private class FlowSinkFromModel extends FlowSink::Range {
private string path;

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy