Guards: Improve support for wrapped guards #20121
Open
+379
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the shared library implementation of guard wrappers by generalizing the wrapper support and simplifying the interface. The changes extend wrapper functionality to handle all return value types (not just booleans), support both normal and exceptional returns, and prepare for wrapped sanitizer support.
- Removes the nested parameterization of
CustomGuard/WrapperGuardmodules to simplify the interface - Generalizes wrapper support to handle all return value types and exceptional/normal returns
- Adds infrastructure for wrapped sanitizers through new
ValidationWrappermodules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| shared/controlflow/codeql/controlflow/Guards.qll | Core implementation with generalized wrapper support, new validation wrapper modules, and simplified interface |
| java/ql/lib/semmle/code/java/controlflow/Guards.qll | Java-specific implementation updates to use new wrapper interface and remove old CustomGuard module |
| java/ql/test/library-tests/guards/Guards.java | Test cases for new wrapper functionality including non-boolean returns and exception handling |
| java/ql/test/library-tests/guards/GuardsInline.expected | Expected test output for new wrapper test cases |
940bd35 to
f0be0ae
Compare
0f20906 to
8d747e9
Compare
|
Dca looks good. A bunch of FPs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the shared library implementation of guard wrappers in several ways. Commit-by-commit review is strongly encouraged.
CustomGuard/WrapperGuardmodule.BarrierGuardto support wrapped sanitizers.