JS: Modeling of aws-sdk clients*
#20135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds modeling for SQL injection detection in AWS SDK clients for both v2 and v3 versions of the AWS SDK. The main purpose is to enable CodeQL to detect SQL injection vulnerabilities when using DynamoDB, S3, Athena, and RDS Data clients with user-provided input.
Key changes include:
- Addition of sink models for SQL injection detection across multiple AWS services
- Addition of source models for database access results (XSS detection)
- Comprehensive test coverage for both v2 and v3 AWS SDK versions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/lib/ext/aws-sdk.model.yml | Core modeling definitions for sinks, sources, and type mappings for AWS SDK clients |
| javascript/ql/test/query-tests/Security/CWE-089/untyped/*.js | Test files demonstrating SQL injection vulnerabilities in various AWS services |
| javascript/ql/test/query-tests/Security/CWE-079/DomBasedXss/aws-db.js | Test file for XSS vulnerabilities from AWS database responses |
| javascript/ql/test/query-tests/Security/CWE-089/untyped/SqlInjection.expected | Expected test results for SQL injection detection |
| javascript/ql/test/query-tests/Security/CWE-079/DomBasedXss/XssWithAdditionalSources.expected | Expected test results for XSS detection |
| javascript/ql/lib/change-notes/2025-07-28-dynamodb.md | Release notes documenting the new AWS SDK support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds modeling for v2 and v3 AWS SDK clients:
client-dynamodbclient-s3client-athenaclient-rds-dataImportant notes:
accessPathLimitto be at least 3:createNamedQueryandupdateNamedQueryin Athena are marked as sinks. They do not execute queries directly but store them for later execution in AWS Athena.