Java: Add test for flexible constructor support #20136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
357ed2f to
3667004
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a library test to verify Java extractor support for flexible constructor bodies, a new language feature introduced in JEP 513 and finalized in Java 25. The test validates that the extractor correctly handles constructors where statements can precede super() or this() calls.
Key changes:
- Creates a new test directory structure for flexible constructor testing
- Adds Java source code demonstrating various flexible constructor scenarios
- Configures the test to use Java 25 with preview features enabled
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/test/library-tests/flexible-constructors/options | Configures extractor to use Java 25 with preview features |
| java/ql/test/library-tests/flexible-constructors/PrintAst.qlref | References the AST printing query for test execution |
| java/ql/test/library-tests/flexible-constructors/PrintAst.expected | Expected AST output for validation |
| java/ql/test/library-tests/flexible-constructors/FlexibleConstructors.java | Test cases demonstrating flexible constructor syntax |
| java/ql/test/library-tests/flexible-constructors/CONSISTENCY/diags.expected | Expected diagnostic output |
Comments suppressed due to low confidence (1)
java/ql/test/library-tests/flexible-constructors/options:2
- Java 25 does not exist as of my knowledge cutoff in January 2025. The latest stable Java version is Java 21 LTS, with Java 22 and 23 being non-LTS releases. Consider using an existing Java version or verify if this is intended for future testing.
//semmle-extractor-options: --javac-args --release 25 --enable-preview
|
The test ought to include field initialization (using both implicit and explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a library test to verify the Java extractor support for flexible constructor bodies, a feature introduced in JEP 513 and finalized in Java 25..
Please ignore any DCA linked.