C++: Fix missing guard conditions for C++ code #20138
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this snippet when compiled as C++:
In C++ code we have the following conversions:
n < m
x
inif(x)
We handled the bool-to-int conversion (i.e., the first conversion) perfectly fine. But the second conversion means that we're not branching on
x
, but rather onx != 0
. And we didn't have any guard logic to handle the fact thatx != 0
impliedn < m
.This PR adds that logic.
Commit-by-commit review recommended:
(Eventually I would like to move C/C++ over to the new shared guards library, but since that's a much larger task I would like to delay that.)