Skip to content

Add Swift as a possible traced language #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Add Swift as a possible traced language #1085

merged 3 commits into from
Jun 3, 2022

Conversation

MathiasVP
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@MathiasVP MathiasVP requested a review from a team as a code owner May 31, 2022 12:50
@aeisenberg
Copy link
Contributor

There are lots of other places we'll need to update as well. Take a look at Languages.ts and see all the things it interacts with. It might be sufficient to only add swift as a new enum value. Not sure.

And, it's probably going to be necessary to add the CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT var to the environment for swift extraction.

At some point (now is probably too early), we're going to want an integration test for swift. Someone on our team can help with that.

@MathiasVP
Copy link
Contributor Author

Thanks for the comments, Andrew! I should have written what my goal with this PR was: We'd like to get Swift support on DCA as soon as possible so that we can monitor extractor and QL performance. If we could get this PR merged onto main it would mean that we didn't have to run DCA on a custom checkout of codeql-action.

There are lots of other places we'll need to update as well. Take a look at Languages.ts and see all the things it interacts with. It might be sufficient to only add swift as a new enum value. Not sure.

It was enough to get past the "Unsupported language: Swift" error I was getting when trying to get DCA working for Swift. Here's a run that shows that it working: https://github.com/dsp-testing/codeql-dca-worker/actions/runs/2414815040.

And, it's probably going to be necessary to add the CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT var to the environment for swift extraction.

Yes, definitely. For now, we're injecting the --internal-use-lua-tracing flag onto codeql database init from DCA, and it sounds like this will be turned on for all of DCA next week. So I didn't include it in this PR to keep it as small as possible.

If you're concerned about this PR not being "complete" before we merge it we can make this PR a draft and continue to use its SHA as a custom checkout for DCA.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying your goal. I think it's fine to get this in so that the narrow use case of DCA is working. We'll need to revisit this later.

@aeisenberg aeisenberg enabled auto-merge June 1, 2022 15:53
@aeisenberg aeisenberg merged commit ccf479d into main Jun 3, 2022
@aeisenberg aeisenberg deleted the swift-support branch June 3, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy