Skip to content

Merge main into releases/v2 #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c8971b8
Update changelog and version after v2.1.16
invalid-email-address Jul 13, 2022
8d24c9e
Update checked-in dependencies
invalid-email-address Jul 13, 2022
d8c9c72
Merge pull request #1141 from github/mergeback/v2.1.16-to-main-3e7e3b32
edoardopirovano Jul 13, 2022
1111129
Update bundle to 2.10.1
alexet Jul 14, 2022
28ccb03
Changelog: Pick the correct PR after opening
alexet Jul 14, 2022
01fa64c
Don't crash if we are unable to get a response from the feature-flag …
criemen Jul 18, 2022
75afbf4
Address review, add test.
criemen Jul 18, 2022
c059f95
Fix lint errors.
criemen Jul 18, 2022
ba95eeb
Merge pull request #1145 from github/criemen/fix-ff-crash
criemen Jul 18, 2022
aa23193
Merge branch 'main' into alexet/codeql-2.10.1-update
alexet Jul 19, 2022
b8bd06e
Merge pull request #1143 from github/alexet/codeql-2.10.1-update
alexet Jul 19, 2022
6fa0b7c
Bump terser from 5.7.1 to 5.14.2 in /runner
dependabot[bot] Jul 20, 2022
8171514
Merge pull request #1146 from github/dependabot/npm_and_yarn/runner/t…
henrymercer Jul 20, 2022
a326649
autobuild-action: Run autobuilders with $CODEQL_RUNNER set.
criemen Jul 21, 2022
ceec52c
Address review.
criemen Jul 21, 2022
2d2dfa3
Remove duplicate CI workflow
adityasharad Jul 25, 2022
dc1c51d
Actions: Fix failing Runner autobuild test on macOS
adityasharad Jul 25, 2022
58faf9d
Actions: Disable the CLR tracer in C# autobuild test
adityasharad Jul 25, 2022
b4ff463
Autobuild: Remove CODEQL_RUNNER workaround
adityasharad Jul 25, 2022
a2f4d66
Runner tests: Read CODEQL_RUNNER from the stored JSON
adityasharad Jul 25, 2022
caa2a0d
Runner tests: Attempt to source the tracer env, display the binary path
adityasharad Jul 27, 2022
bbc2e70
Merge pull request #1149 from github/criemen/runner-autobuilders
adityasharad Jul 27, 2022
0dd6a6f
Update changelog for v2.1.17
invalid-email-address Jul 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors.
  • Loading branch information
criemen authored Jul 18, 2022
commit c059f95c05ed66ed03ad4356151713bf340f4754
2 changes: 1 addition & 1 deletion lib/feature-flags.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/feature-flags.test.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions src/feature-flags.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ const ALL_FEATURE_FLAGS_DISABLED_VARIANTS: Array<{
description: string;
gitHubVersion: util.GitHubVersion;
}> = [
{
description: "GHES",
gitHubVersion: { type: GitHubVariant.GHES, version: "3.0.0" },
},
{ description: "GHAE", gitHubVersion: { type: GitHubVariant.GHAE } },
];
{
description: "GHES",
gitHubVersion: { type: GitHubVariant.GHES, version: "3.0.0" },
},
{ description: "GHAE", gitHubVersion: { type: GitHubVariant.GHAE } },
];

for (const variant of ALL_FEATURE_FLAGS_DISABLED_VARIANTS) {
test(`All feature flags are disabled if running against ${variant.description}`, async (t) => {
Expand All @@ -60,7 +60,7 @@ for (const variant of ALL_FEATURE_FLAGS_DISABLED_VARIANTS) {
(v: LoggedMessage) =>
v.type === "debug" &&
v.message ===
"Not running against github.com. Disabling all feature flags."
"Not running against github.com. Disabling all feature flags."
) !== undefined
);
});
Expand Down Expand Up @@ -122,7 +122,7 @@ test("Feature flags are disabled if they're not returned in API response", async
(v: LoggedMessage) =>
v.type === "debug" &&
v.message ===
`Feature flag '${featureFlag}' undefined in API response, considering it disabled.`
`Feature flag '${featureFlag}' undefined in API response, considering it disabled.`
) !== undefined
);
}
Expand Down
8 changes: 4 additions & 4 deletions src/feature-flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class GitHubFeatureFlags implements FeatureFlags {
private apiDetails: GitHubApiDetails,
private repositoryNwo: RepositoryNwo,
private logger: Logger
) { }
) {}

async getValue(flag: FeatureFlag): Promise<boolean> {
const response = await this.getApiResponse();
Expand Down Expand Up @@ -71,9 +71,9 @@ export class GitHubFeatureFlags implements FeatureFlags {
if (util.isHTTPError(e) && e.status === 403) {
this.logger.warning(
"This run of the CodeQL Action does not have permission to access Code Scanning API endpoints. " +
"As a result, it will not be opted into any experimental features. " +
"This could be because the Action is running on a pull request from a fork. If not, " +
`please ensure the Action has the 'security-events: write' permission. Details: ${e}`
"As a result, it will not be opted into any experimental features. " +
"This could be because the Action is running on a pull request from a fork. If not, " +
`please ensure the Action has the 'security-events: write' permission. Details: ${e}`
);
} else {
// Some feature flags, such as `ml_powered_queries_enabled` affect the produced alerts.
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy