Skip to content

Split debug artifacts PR check into two jobs #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 4, 2022
Merged

Split debug artifacts PR check into two jobs #1160

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
81c5b2d
New debug artifacts workflow with separate jobs
angelapwen Aug 1, 2022
cc047a3
Condense matrix syntax
angelapwen Aug 2, 2022
13e7a52
Change download job to only run on linux
angelapwen Aug 2, 2022
64d83c7
Fix syntax error
angelapwen Aug 2, 2022
ef145d6
Display downloaded file structure
angelapwen Aug 3, 2022
f7a7ac1
bash syntax fixup
angelapwen Aug 3, 2022
f51da86
Add script to check in appropriate directories
angelapwen Aug 3, 2022
e16d085
Remove ls check, log formatting
angelapwen Aug 3, 2022
4ec485d
bash syntax fixup per review
angelapwen Aug 3, 2022
2a582eb
Merge branch 'main' into angelapwen/refactor-debug-artifacts-pr-check
angelapwen Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove ls check, log formatting
  • Loading branch information
@angelapwen
angelapwen committed Aug 3, 2022
commit e16d085a47850ebcd88cf09e955f002f5db803f4
6 changes: 2 additions & 4 deletions .github/workflows/debug-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ jobs:
steps:
- name: Download all artifacts
uses: actions/download-artifact@v3
- name: Display structure of downloaded files
run: ls -R
- name: Check expected artifacts exist
shell: bash
run: |
Expand All @@ -62,9 +60,9 @@ jobs:
for os in $OPERATING_SYSTEMS; do
for version in $VERSIONS; do
cd ./my-debug-artifacts-$os-$version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes not essential but a good habit.
I observe this cd will fail if the artifact dir doesn't exist, but I think that's ok and will give us a reasonable error message. We can improve it in future if necessary.

Suggested change
cd ./my-debug-artifacts-$os-$version
cd "./my-debug-artifacts-$os-$version"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting.. I wonder if it fails if it will continue onto the next directory? Probably not..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not. This is because by default Actions runs bash steps with set -e (set -eo pipefail specifically; see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell), so any shell command exiting non-zero will fail the entire step.

You can turn this off in a given step by adding set +e at the beginning, but we don't need that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Thanks!

echo "Checking version $version on $os"
echo "Artifacts from version $version on $os:"
for language in $LANGUAGES; do
echo "Checking $language"
echo "- Checking $language"
if [[ ! -f "$language.sarif" ]] ; then
echo "Missing a SARIF file for $language"
exit 1
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy