Skip to content

Add support for downloading packs from GHES #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 8, 2022
Merged

Add support for downloading packs from GHES #1221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c7bb894
Update changelog
aeisenberg Aug 29, 2022
0e98efa
Add support for downloading packs from GHES
aeisenberg Aug 29, 2022
1d92118
Add integration test for using `registries-auth-tokens`
aeisenberg Aug 30, 2022
e9b47b1
Change to using a single input
aeisenberg Sep 1, 2022
b044362
Merge branch 'main' into aeisenberg/ghes-pack-download
aeisenberg Sep 2, 2022
abdf26c
Convert from json to yaml for registries input
aeisenberg Sep 2, 2022
7e086b2
Merge remote-tracking branch 'upstream/main' into aeisenberg/ghes-pac…
aeisenberg Sep 6, 2022
bf97a6d
Apply suggestions from code review
aeisenberg Sep 6, 2022
376fea6
Clarify description of `registries` input
aeisenberg Sep 6, 2022
4fa3e8b
Gate the new `registries` input behind version constraints
aeisenberg Sep 7, 2022
5dcb9de
Update changelog and input descriptions
aeisenberg Sep 7, 2022
aa434aa
Only run the init-with-registries check on nightly
aeisenberg Sep 7, 2022
5974446
Fix unit tests
aeisenberg Sep 7, 2022
6085805
Append `/` to end of registries url
aeisenberg Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into aeisenberg/ghes-pack-download
  • Loading branch information
@aeisenberg
aeisenberg committed Sep 2, 2022
commit b0443622cdd831f6684d89f4c5da53e384917a43
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ No user facing changes.

- Downloading CodeQL packs has been moved to the `init` step. Previously, CodeQL packs were downloaded during the `analyze` step. [#1218](https://github.com/github/codeql-action/pull/1218)
- Allow CodeQL packs to be downloaded from GitHub Enterprise Server instances. [#1221](https://github.com/github/codeql-action/pull/1221)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we mention the registries field here briefly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this entry is in the wrong version. I'll change that, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to link to the documentation when it is available, but that won't be out for a while.

- Update default CodeQL bundle version to 2.10.4. [#1224](https://github.com/github/codeql-action/pull/1224)
- The newly released [Poetry 1.2](https://python-poetry.org/blog/announcing-poetry-1.2.0) is not yet supported. In the most common case where the CodeQL Action is automatically installing Python dependencies, it will continue to install and use Poetry 1.1 on its own. However, in certain cases such as with self-hosted runners, you may need to ensure Poetry 1.1 is installed yourself.

## 2.1.21 - 25 Aug 2022

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy