Skip to content

Make Go a traced language when Go extraction reconciliation is enabled #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 2, 2022
Merged

Make Go a traced language when Go extraction reconciliation is enabled #1228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf5d465
Trace Go when Go extraction reconciliation is enabled
henrymercer Sep 1, 2022
6d34731
Make `createdDBForScannedLanguages` test robust to new async calls
henrymercer Sep 1, 2022
e460fa2
Tidy up `createdDBForScannedLanguages`
henrymercer Sep 1, 2022
e303e2c
Update legacy workflow PR check
henrymercer Sep 1, 2022
1d311fe
Add PR checks for reconciled tracing with autobuilder and build steps
henrymercer Sep 1, 2022
6699d47
Work around `test -v` not being available in Mac Bash
henrymercer Sep 1, 2022
62b4f23
Merge remote-tracking branch 'origin/main' into henrymercer/start-go-…
henrymercer Sep 2, 2022
4b5dea8
Address review comments
henrymercer Sep 2, 2022
fc2f344
Reuse `getApiDetails` code
henrymercer Sep 2, 2022
ab4197c
Merge remote-tracking branch 'origin/main' into henrymercer/start-go-…
henrymercer Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@henrymercer
henrymercer committed Sep 2, 2022
commit 4b5dea8eed44456f3e57d76ac8e0a770c75be493
1 change: 0 additions & 1 deletion lib/autobuild-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/autobuild-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/languages.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/languages.test.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/autobuild-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ async function run() {

const apiDetails = {
auth: getRequiredInput("token"),
externalRepoAuth: getOptionalInput("external-repository-token"),
url: getRequiredEnvParam("GITHUB_SERVER_URL"),
apiURL: getRequiredEnvParam("GITHUB_API_URL"),
};
Expand Down
2 changes: 1 addition & 1 deletion src/languages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test("parseLanguage", async (t) => {
for (const isReconciliationOn of [false, true]) {
test(`isTracedLanguage (go reconciliation ${
isReconciliationOn ? "enabled" : "disabled"
}`, async (t) => {
})`, async (t) => {
const logger = getRunnerLogger(true);

t.true(isTracedLanguage(Language.cpp, isReconciliationOn, logger));
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy