Skip to content

Merge releases/v2 into releases/v1 #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 17, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
885b397
Update changelog and version after v2.1.26
invalid-email-address Sep 29, 2022
ffa74c5
Update checked-in dependencies
invalid-email-address Sep 29, 2022
0831a67
Merge pull request #1277 from github/mergeback/v2.1.26-to-main-e0e5ded3
cklin Sep 29, 2022
57719e0
Don't check for Go logs on failure (#1279)
angelapwen Sep 29, 2022
61b87c6
Update supported GitHub Enterprise Server versions. (#1275)
github-actions[bot] Sep 29, 2022
c0641ea
TRAP Caching: Add timeouts to upload/download operations
edoardopirovano Sep 30, 2022
4cf8004
Merge pull request #1280 from github/edoardo/add-timeout
edoardopirovano Sep 30, 2022
6ace05b
Add logging statements declaring state of the cli_config_file_enabled
aeisenberg Sep 30, 2022
59fbe34
Avoid using single value as array
aeisenberg Oct 2, 2022
5960ce1
Extract logging statements to separate function
aeisenberg Oct 3, 2022
f359ba7
Merge pull request #1281 from github/aeisenberg/cli-config-processing
aeisenberg Oct 4, 2022
24c8de1
Correctly report CodeQL version when using cache (#1259)
angelapwen Oct 5, 2022
9e044c5
Convert "Invalid source root" errors to UserErrors
aeisenberg Oct 4, 2022
84dffe7
Merge pull request #1282 from github/aeisenberg/user-error-source-root
aeisenberg Oct 6, 2022
e4cc4a2
Add changelog note for Go extraction reconciliation (#1286)
angelapwen Oct 6, 2022
c2f5185
Merge commit 'e4cc4a2f' into releases/v2
aeisenberg Oct 17, 2022
4c1ccc4
Fix CHANGELOG
aeisenberg Oct 17, 2022
5dd7367
Merge pull request #1308 from github/aeisenberg/fix-merge
aeisenberg Oct 17, 2022
09aebd0
Revert "Update version and changelog for v1.1.27"
invalid-email-address Oct 17, 2022
c9864f3
Revert "Update checked-in dependencies"
invalid-email-address Oct 17, 2022
27694b3
Merge remote-tracking branch 'origin/releases/v2' into update-v1.1.27…
invalid-email-address Oct 17, 2022
a0e10fe
Update version and changelog for v1.1.27
invalid-email-address Oct 17, 2022
6bb11c6
Update checked-in dependencies
invalid-email-address Oct 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions lib/init.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/init.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 37 additions & 18 deletions src/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,24 +117,7 @@ export async function runInit(
}
}
} catch (e) {
// Handle the situation where init is called twice
// for the same database in the same job.
if (
e instanceof Error &&
e.message?.includes("Refusing to create databases") &&
e.message.includes("exists and is not an empty directory.")
) {
throw new util.UserError(
`Is the "init" action called twice in the same job? ${e.message}`
);
} else if (
e instanceof Error &&
e.message?.includes("is not compatible with this CodeQL CLI")
) {
throw new util.UserError(e.message);
} else {
throw e;
}
throw processError(e);
}
return await getCombinedTracerConfig(
config,
Expand All @@ -144,6 +127,42 @@ export async function runInit(
);
}

/**
* Possibly convert this error into a UserError in order to avoid
* counting this error towards our internal error budget.
*
* @param e The error to possibly convert to a UserError.
*
* @returns A UserError if the error is a known error that can be
* attributed to the user, otherwise the original error.
*/
function processError(e: any): Error {
if (!(e instanceof Error)) {
return e;
}

if (
// Init action called twice
e.message?.includes("Refusing to create databases") &&
e.message?.includes("exists and is not an empty directory.")
) {
return new util.UserError(
`Is the "init" action called twice in the same job? ${e.message}`
);
}

if (
// Version of CodeQL CLI is incompatible with this version of the CodeQL Action
e.message?.includes("is not compatible with this CodeQL CLI") ||
// Expected source location for database creation does not exist
e.message?.includes("Invalid source root")
) {
return new util.UserError(e.message);
}

return e;
}

// Runs a powershell script to inject the tracer into a parent process
// so it can tracer future processes, hopefully including the build process.
// If processName is given then injects into the nearest parent process with
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy