Skip to content

Make PR checks compatible with the latest version of the ubuntu-latest runner image #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Make PR checks compatible with the latest version of the ubuntu-latest runner image #1330

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f248a57
Run PR checks for CLIs < 2.7.3 on `ubuntu-20.04`
henrymercer Oct 27, 2022
5767f91
Remove redundant `fail-fast` configurations
henrymercer Oct 27, 2022
7342926
Update non-generated checks for `ubuntu-latest` image update
henrymercer Oct 27, 2022
4ed5abe
Remove redundant Rubocop checks
henrymercer Oct 27, 2022
a312004
Be more specific about where the 2.7.3 constraint comes from
henrymercer Oct 27, 2022
993ca05
Fix artifact lookup for `ubuntu-20.04`
henrymercer Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Be more specific about where the 2.7.3 constraint comes from
  • Loading branch information
@henrymercer
henrymercer committed Oct 27, 2022
commit a31200481fb3229ff8335ecaeecd4517b2b39235
4 changes: 2 additions & 2 deletions pr-checks/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def isCompatibleWithLatestImages(version):
if version in ["cached", "latest", "nightly-latest"]:
return True
date = version.split("-")[1]
# The first version of the CodeQL CLI compatible with the latest runner images is 2.7.3.
# This appears in CodeQL Bundle version codeql-bundle-20211208.
# The first version of the CodeQL CLI compatible with `ubuntu-22.04` and `windows-2022` is
# 2.7.3. This appears in CodeQL Bundle version codeql-bundle-20211208.
return date >= "20211208"


Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy