Skip to content

Kotlin: CodeQL >= 2.13.4 supports 1.9.10. #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Kotlin: CodeQL >= 2.13.4 supports 1.9.10. #1853

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e581348
Kotlin: CodeQL >= 2.13.4 supports 1.9.10.
igfoo Aug 24, 2023
30fe0c4
npm run build
igfoo Aug 24, 2023
ff95d14
Kotlin: Fix lint
igfoo Aug 24, 2023
070dd05
npm run build
igfoo Aug 24, 2023
862b2cf
Add a changelog entry for the Kotlin 1.9.10 support
igfoo Aug 24, 2023
7dab600
Put upper limit on the CodeQL versions for which we override the Kotl…
igfoo Aug 24, 2023
2f913c1
npm run build
igfoo Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put upper limit on the CodeQL versions for which we override the Kotl… 
…in limit

Otherwise it'll be lower than the default at some point in the future.
  • Loading branch information
@igfoo
igfoo committed Aug 24, 2023
commit 7dab60079ba615275bc07067ee108dfa7ebec60a
5 changes: 4 additions & 1 deletion src/init-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,10 @@ async function run() {

const kotlinLimitVar =
"CODEQL_EXTRACTOR_KOTLIN_OVERRIDE_MAXIMUM_VERSION_LIMIT";
if (await codeQlVersionAbove(codeql, "2.13.4")) {
if (
(await codeQlVersionAbove(codeql, "2.13.4")) &&
!(await codeQlVersionAbove(codeql, "2.14.4"))
) {
core.exportVariable(kotlinLimitVar, "1.9.20");
}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy