-
Notifications
You must be signed in to change notification settings - Fork 376
Add a fix for python 3.12 #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add integration test
Also: - Update changelog - Fix comments in check_python script
- Loading branch information
commit 028bacb8e9c13fef2063aff0419b99212f30c374
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Test that the workaround for python 3.12 on windows works | ||
|
||
on: | ||
push: | ||
branches: [main, releases/v2] | ||
pull_request: | ||
# Run checks on reopened draft PRs to support triggering PR checks on draft PRs that were opened | ||
# by other workflows. | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
schedule: | ||
# Weekly on Monday. | ||
- cron: '0 0 * * 1' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
test-setup-python-scripts: | ||
timeout-minutes: 45 | ||
runs-on: windows-latest | ||
|
||
steps: | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.12 | ||
|
||
- uses: actions/checkout@v4 | ||
|
||
- name: Prepare test | ||
uses: ./.github/actions/prepare-test | ||
with: | ||
version: default | ||
|
||
- name: Initialize CodeQL | ||
uses: ./../init | ||
with: | ||
tools: latest | ||
languages: python | ||
|
||
- name: Analyze | ||
uses: ./../action/analyze | ||
with: | ||
upload-database: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,16 +4,16 @@ | |||||
# If we are running greater than or equal to python 3.12, change py to run version 3.11 | ||||||
Write-Host "Checking python version" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Super-nit There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, I think all |
||||||
if ((py -3 -c "import sys; print(0 if sys.version_info >= (3, 12) else 1)") -eq "0") { | ||||||
Write-Host "Python 3.12+ detected, setting PY_PYTHON3=3.11" | ||||||
Write-Host "python 3.12+ detected, setting PY_PYTHON3=3.11" | ||||||
# First make sure we have python 3.11 installed | ||||||
py -3.11 -c "import imp" | ||||||
if ($LASTEXITCODE -eq 0) { | ||||||
Write-Host "Python 3.11 detected, using this version instead of 3.12+." | ||||||
Write-Host "python 3.11 detected, using this version instead of 3.12+." | ||||||
Write-Output "PY_PYTHON3=3.11" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append | ||||||
} else { | ||||||
Write-Host "FAILURE: Python 3.12+ is not supported. Please install Python 3.11." | ||||||
Write-Host "FAILURE: Python 3.12+ is not supported, and Python 3.11 could not be detected on the system. Please install Python 3.11." | ||||||
exit 1 | ||||||
} | ||||||
} else { | ||||||
Write-Host "Python 3.12+ not detected, not making any changes." | ||||||
Write-Host "python 3.12+ not detected, not making any changes." | ||||||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.