Skip to content

Refactor configuration errors #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename variable for clarity
  • Loading branch information
angelapwen committed Feb 6, 2024
commit d64851b15853a9708f78e886b41a987369c9d6d0
6 changes: 3 additions & 3 deletions lib/cli-errors.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/cli-errors.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/cli-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ type CliErrorConfiguration = {
exitCode?: number;
// Error message to prepend for this type of CLI error.
// If undefined, use original CLI error message.
actionErrorMessage?: string;
additionalErrorMessageToPrepend?: string;
};

/**
Expand All @@ -130,7 +130,7 @@ export const cliErrorsConfig: Record<
"Refusing to create databases",
"exists and is not an empty directory",
],
actionErrorMessage: `Is the "init" action called twice in the same job?`,
additionalErrorMessageToPrepend: `Is the "init" action called twice in the same job?`,
},
// Expected source location for database creation does not exist
[CliConfigErrorCategory.InvalidSourceRoot]: {
Expand All @@ -147,7 +147,7 @@ export const cliErrorsConfig: Record<
[CliConfigErrorCategory.NoJavaScriptTypeScriptCodeFound]: {
exitCode: 32,
cliErrorMessageSnippets: ["No JavaScript or TypeScript code found."],
actionErrorMessage:
additionalErrorMessageToPrepend:
"No code found during the build. Please see: " +
"https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build.",
},
Expand Down Expand Up @@ -199,7 +199,7 @@ export function wrapCliConfigurationError(cliError: Error): Error {
}

const errorMessageWrapperIfExists =
cliErrorsConfig[cliConfigErrorCategory].actionErrorMessage;
cliErrorsConfig[cliConfigErrorCategory].additionalErrorMessageToPrepend;

return errorMessageWrapperIfExists
? new ConfigurationError(
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy