-
Notifications
You must be signed in to change notification settings - Fork 376
Add common CLI configuration error categories #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c45840d
Add common CLI configuration error categories
angelapwen d51e49a
Drive-by: appease enum type warning
angelapwen 9bc1f4d
Drive-by: tiny workflow improvement
angelapwen e45c9a6
Stop using exit code 32 for new category
angelapwen 1e5200d
Actually wrap errors from autobuild command
angelapwen aeac6ec
Drive-by: more type appeasing
angelapwen 7e39cda
Revert unnecessary casting
angelapwen 8361861
Generalize exit code 32 to no code found error
angelapwen 9b0da38
Update comment
angelapwen bddc0a0
Add logic to prepend docs link if necessary
angelapwen 9f5ccaf
Use regex matching for tests with exit code 32
angelapwen 435692c
Append additional error message instead of prepend
angelapwen a18a72e
Fix regex in tests: properly escape `.` character
angelapwen cefd39b
Correctly handle additional error message to append case
angelapwen e1e0ba3
Fold no source code found errors into one
angelapwen bce391b
Regex fixups
angelapwen 3dc47a2
Rename `snippets` to `candidates` for clarity.
angelapwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Stop using exit code 32 for new category
This clashes with the logic for the `NoJavaScriptTypeScriptCodeFound` case. Once that situation is deprecated, we can add the exit code back to `DetectedCodeButCouldNotProcess` configuration.
- Loading branch information
commit e45c9a673794867dc696045ff579466854754abc
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.