Skip to content

Use github merge-results command for merging SARIF files #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 27, 2024
Merged

Use github merge-results command for merging SARIF files #2199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a12b868
Create feature flag for merging SARIF files using the CLI
koesie10 Mar 15, 2024
ccc609b
Use github merge-results command when feature flag is enabled
koesie10 Mar 15, 2024
7e30c62
Use subdirectory for combined SARIF file
koesie10 Mar 18, 2024
2bbafcd
Upload debug artifacts for upload-sarif
koesie10 Mar 18, 2024
e20c273
Use supportsFeature check for merging SARIF files
koesie10 Mar 22, 2024
6ac5753
Use options object instead of boolean for mergeResults
koesie10 Mar 25, 2024
70aa50b
Use runTool for mergeResults
koesie10 Mar 25, 2024
3bd271c
Introduce areAllRunsProducedByCodeQL function
koesie10 Mar 25, 2024
a0a63a2
Do not try merging a single SARIF file
koesie10 Mar 25, 2024
3c4b8bc
Change log levels
koesie10 Mar 25, 2024
82b82e5
Only upload combined SARIF files when env var is set
koesie10 Mar 25, 2024
58194bf
Do not require debug mode for debugging uploads
koesie10 Mar 26, 2024
f835435
Rename run to uploadArtifacts
koesie10 Mar 26, 2024
016720d
Refactor areAllRunsProducedByCodeQL to use Array.every
koesie10 Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename run to uploadArtifacts
  • Loading branch information
@koesie10
koesie10 committed Mar 26, 2024
commit f835435c19cd767fadcb37b05f1c57b96f2a2ec2
2 changes: 1 addition & 1 deletion lib/analyze-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action-post.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/upload-sarif-action-post-helper.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/upload-sarif-action-post-helper.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/upload-sarif-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/upload-sarif-action-post.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src/analyze-action-post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ async function runWrapper() {

// Also run the upload-sarif post action since we're potentially running
// the same steps in the analyze action.
await uploadSarifActionPostHelper.run(debugArtifacts.uploadDebugArtifacts);
await uploadSarifActionPostHelper.uploadArtifacts(
debugArtifacts.uploadDebugArtifacts,
);
} catch (error) {
core.setFailed(
`analyze post-action step failed: ${wrapError(error).message}`,
Expand Down
2 changes: 1 addition & 1 deletion src/upload-sarif-action-post-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as core from "@actions/core";

import * as actionsUtil from "./actions-util";

export async function run(
export async function uploadArtifacts(
uploadDebugArtifacts: (
toUpload: string[],
rootDir: string,
Expand Down
4 changes: 3 additions & 1 deletion src/upload-sarif-action-post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ import { wrapError } from "./util";

async function runWrapper() {
try {
await uploadSarifActionPostHelper.run(debugArtifacts.uploadDebugArtifacts);
await uploadSarifActionPostHelper.uploadArtifacts(
debugArtifacts.uploadDebugArtifacts,
);
} catch (error) {
core.setFailed(
`upload-sarif post-action step failed: ${wrapError(error).message}`,
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy