Skip to content

Improve reliability and performance when using the autobuild build mode #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 16, 2024
Merged

Improve reliability and performance when using the autobuild build mode #2235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5b74166
Move `BuildMode` to `util.ts`
henrymercer Apr 11, 2024
e37d0f3
Use direct tracing when autobuild build mode specified
henrymercer Apr 11, 2024
3d49faa
Use extraction via build mode in `autobuild` Action when available
henrymercer Apr 11, 2024
8f057a3
Apply network timeout fix to extraction with direct tracing
henrymercer Apr 11, 2024
cbe29f5
Run autobuild script via direct tracing when feature enabled
henrymercer Apr 11, 2024
2eaad47
Add changelog note
henrymercer Apr 12, 2024
aa4a08d
Add PR check for direct tracing
henrymercer Apr 12, 2024
f21d2d2
Merge branch 'main' into henrymercer/autobuild-with-direct-tracing
henrymercer Apr 12, 2024
59771dd
Run PR check on Windows too
henrymercer Apr 15, 2024
14eab91
Improve changelog note
henrymercer Apr 15, 2024
ea78e51
Merge branch 'main' into henrymercer/autobuild-with-direct-tracing
henrymercer Apr 15, 2024
db2b739
Fix PR link in changelog
henrymercer Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run PR check on Windows too
  • Loading branch information
@henrymercer
henrymercer committed Apr 15, 2024
commit 59771ddf53425b09fd0824453a0e2ecb4bf69ab0
6 changes: 6 additions & 0 deletions .github/workflows/__autobuild-direct-tracing.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pr-checks/checks/autobuild-direct-tracing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
name: "Autobuild direct tracing"
description: "An end-to-end integration test of a Java repository built using 'build-mode: autobuild', with direct tracing enabled"
operatingSystems: ["ubuntu"]
operatingSystems: ["ubuntu", "windows"]
versions: ["latest", "nightly-latest"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to fix in this PR, but how can we ensure that as we release new versions of the CLI, we add them to the matrix? There are other integration tests that only run on "latest", "nightly-latest" because when we wrote them, those were the only versions that supported the feature being tested.

Could we add a minimum-version property so that tests that specify it run on all CLI versions >= the minimum version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, but I think it's beyond the scope of this PR. I'll file an issue.

env:
CODEQL_ACTION_AUTOBUILD_BUILD_MODE_DIRECT_TRACING: true
steps:
- name: Set up Java test repo configuration
shell: bash
run: |
mv * .github ../action/tests/multi-language-repo/
mv ../action/tests/multi-language-repo/.github/workflows .github
Expand All @@ -20,6 +21,7 @@ steps:
tools: ${{ steps.prepare-test.outputs.tools-url }}

- name: Check that indirect tracing is disabled
shell: bash
run: |
if [[ ! -z "${CODEQL_RUNNER}" ]]; then
echo "Expected indirect tracing to be disabled, but the" \
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy