Skip to content

Check zstd is on the path in addition to tar version #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Check zstd is on the path in addition to tar version #2526

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
057e1ec
Check zstd is on the path in addition to tar version
henrymercer Oct 4, 2024
bf2e624
Update src/tar.ts
henrymercer Oct 7, 2024
d65a176
Rebuild
github-actions[bot] Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/tar.ts 
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
  • Loading branch information
@henrymercer @aeisenberg
henrymercer and aeisenberg authored Oct 7, 2024
commit bf2e624d0b3b15a9fe5c6ae1294f207a8f2ee3f1
2 changes: 1 addition & 1 deletion src/tar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export async function isZstdAvailable(
}
} catch (e) {
logger.warning(
"Failed to determine tar version, therefore will assume zstd may not be available. " +
"Failed to determine tar version, therefore will assume zstd is not available. " +
`The underlying error was: ${e}`,
);
return { available: false, foundZstdBinary };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for knowing if zstd is available if we can't figure out what tar version is available?

Actually, I'm not sure what the use case for having foundZstdBinary as part of the interface is. Is this for telemetry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for knowing if zstd is available if we can't figure out what tar version is available?

If we can't figure out what tar version is available, we want to fall back to gzip.

Actually, I'm not sure what the use case for having foundZstdBinary as part of the interface is. Is this for telemetry?

Yes, this is just to help us understand how much of the time zstd wasn't available due to the tar version and how much of the time it wasn't available due to not being able to find a zstd binary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy