Improve logging

github · henrymercer · Oct 14, 2024 · Oct 9, 2024 · Oct 10, 2024 · Oct 10, 2024
commit 90c42c41ec3c4dd6d8cc98601872d0653f7b5da9
@@ -544,7 +544,9 @@ export async function getCodeQLForCmd(
     async getVersion() {
       let result = util.getCachedCodeQlVersion();
       if (result === undefined) {
-        const output = await runCli(cmd, ["version", "--format=json"]);
+        const output = await runCli(cmd, ["version", "--format=json"], {
+          noStreamStdout: true,
+        });
         try {
           result = JSON.parse(output) as VersionInfo;
         } catch {

@@ -517,9 +517,6 @@ export const downloadCodeQL = async function (
   } else {
     logger.debug("Downloading CodeQL tools without an authorization token.");
   }
-  logger.info(
-    `Downloading CodeQL tools from ${codeqlURL} . This may take a while.`,
-  );
 
   const { extractedBundlePath, statusReport } = await downloadAndExtract(
     codeqlURL,
@@ -552,12 +549,19 @@ export const downloadCodeQL = async function (
     bundleVersion,
     logger,
   );
+  const toolcacheStart = performance.now();
   const toolcachedBundlePath = await toolcache.cacheDir(
     extractedBundlePath,
     "CodeQL",
     toolcacheVersion,
   );
 
+  logger.info(
+    `Added CodeQL bundle to the tool cache (${
+      performance.now() - toolcacheStart
+    } ms).`,
+  );
+
   // Defensive check: we expect `cacheDir` to copy the bundle to a new location.
   if (toolcachedBundlePath !== extractedBundlePath) {
     await cleanUpGlob(

@@ -53,12 +53,18 @@ export async function downloadAndExtract(
   extractedBundlePath: string;
   statusReport: ToolsDownloadStatusReport;
 }> {
+  logger.info(
+    `Downloading CodeQL tools from ${codeqlURL} . This may take a while.`,
+  );
+
   const compressionMethod = tar.inferCompressionMethod(codeqlURL);
 
   if (
     compressionMethod === "zstd" &&
     (await features.getValue(Feature.ZstdBundleStreamingExtraction))
   ) {
+    logger.info(`Streaming the extraction of the CodeQL bundle.`);
+
     const toolsInstallStart = performance.now();
     const extractedBundlePath = await downloadAndExtractZstdWithStreaming(
       codeqlURL,