Skip to content

Merge main into releases/v3 #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Merge main into releases/v3 #2601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a25759
Update changelog and version after v3.27.2
github-actions[bot] Nov 12, 2024
a4ee280
Update checked-in dependencies
github-actions[bot] Nov 12, 2024
5cb4249
Merge pull request #2595 from github/mergeback/v3.27.2-to-main-9278e421
henrymercer Nov 12, 2024
e6dd404
workaround: disable streaming when downloading codeql bundle
NlightNFotis Nov 12, 2024
5445a29
tests: instead of false, use old feature flag with default value of f…
NlightNFotis Nov 12, 2024
427ce46
doc: add issue link to todo reminders in tests
NlightNFotis Nov 12, 2024
f047903
Merge pull request #2599 from github/NlightNFotis/disable-streaming
NlightNFotis Nov 12, 2024
2b13194
Update changelog for v3.27.3
github-actions[bot] Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
workaround: disable streaming when downloading codeql bundle
  • Loading branch information
@NlightNFotis
NlightNFotis committed Nov 12, 2024
commit e6dd4048e948138fdedb84209e7f981c0a31c5f6
4 changes: 3 additions & 1 deletion lib/tools-download.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/tools-download.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src/tools-download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ export async function downloadAndExtract(

const compressionMethod = tar.inferCompressionMethod(codeqlURL);

if (compressionMethod === "zstd" && process.platform === "linux") {
// TODO: Re-enable streaming when we have a more reliable way to respect proxy settings.
// eslint-disable-next-line no-constant-condition, no-constant-binary-expression
if (false && compressionMethod === "zstd" && process.platform === "linux") {
logger.info(`Streaming the extraction of the CodeQL bundle.`);

const toolsInstallStart = performance.now();
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy