Skip to content

Enable Feature.DiffInformedQueries #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

Enable Feature.DiffInformedQueries #2970

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aefb854
Feature.DiffInformedQueries: default to true
cklin Jul 16, 2025
614b64c
Diff-informed analysis: disable for GHES below 3.19
cklin Jul 17, 2025
3aef410
Add diff-informed-analysis-utils.test.ts
cklin Jul 17, 2025
6a49a8c
build: refresh js files
cklin Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Diff-informed analysis: disable for GHES below 3.19
  • Loading branch information
@cklin
cklin committed Jul 17, 2025
commit 614b64c6ec97a4ad54f7c99c5becbf593144dbfb
10 changes: 10 additions & 0 deletions src/diff-informed-analysis-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ import * as path from "path";

import * as actionsUtil from "./actions-util";
import type { PullRequestBranches } from "./actions-util";
import { getGitHubVersion } from "./api-client";
import type { CodeQL } from "./codeql";
import { Feature, FeatureEnablement } from "./feature-flags";
import { Logger } from "./logging";
import { GitHubVariant, satisfiesGHESVersion } from "./util";

/**
* Check if the action should perform diff-informed analysis.
Expand Down Expand Up @@ -37,6 +39,14 @@ export async function getDiffInformedAnalysisBranches(
return undefined;
}

const gitHubVersion = await getGitHubVersion();
if (
gitHubVersion.type === GitHubVariant.GHES &&
satisfiesGHESVersion(gitHubVersion.version, "<3.19", true)
) {
return undefined;
}

const branches = actionsUtil.getPullRequestBranches();
if (!branches) {
logger.info(
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy