Skip to content

Ensure config path comparisons don't fail where workspace path is a symlink #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2020
Merged

Ensure config path comparisons don't fail where workspace path is a symlink #67

merged 5 commits into from
Jun 18, 2020

Conversation

sampart
Copy link
Contributor

@sampart sampart commented Jun 16, 2020 •
edited
Loading

Before this change, config-utils.ts › load non-empty input was failing on Mac with:

The configuration file "/var/folders/gx/y8v1507s29d97m1r_5kq0s000000gn/T/codeql-action-oum66d/input" is invalid: property "queries.uses" is invalid as the local path "" is outside of the repository

The reason is that the tmp directory (which is where the config file was put by the test) was a symlink.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

sampart added 2 commits June 16, 2020 16:59
@sampart
Fix config path comparisons where workspace path is a symlink
0b53ebb 
Before this change, config-utils.ts › load non-empty input was failing on Mac with:

The configuration file "/var/folders/gx/y8v1507s29d97m1r_5kq0s000000gn/T/codeql-action-oum66d/input" is invalid: property "queries.uses" is invalid as the local path "" is outside of the repository

The reason is that the tmp directory (which is where the config file was put by the test) was a symlink.
@sampart
Apply realpathSync sooner
013c027 
Fixes lint: https://github.com/github/codeql-action/pull/67/checks?check_run_id=777215812
@sampart sampart requested a review from Daverlo June 16, 2020 16:04
Daverlo
Daverlo approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@Daverlo Daverlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sampart sampart merged commit 608ed15 into master Jun 18, 2020
@sampart sampart deleted the dont-fail-on-symlinks branch June 18, 2020 08:21
@github-actions github-actions bot mentioned this pull request Jun 22, 2020
Merged
@robertbrignull robertbrignull mentioned this pull request Jun 23, 2020
Merged
4 tasks
@SwuduSusuwu SwuduSusuwu mentioned this pull request Jul 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daverlo Daverlo Daverlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampart @Daverlo
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy